T2b REQUEST CHANGES

Blocking: src/app/chain/page.tsx discards query params on redirect. The comment says "Forward any query params" but void searchParams explicitly drops them, so /chain?storyline=123 → /create?tab=chain (loses storyline=123).

Fix: await searchParams and forward them:

export default async function ChainRedirect({
  searchParams,
}: {
  searchParams: Promise<Record<string, string>>;
}) {
  const params = await searchParams;
  const qs = new URLSearchParams(params).toString();
  redirect("/create?tab=chain" + (qs ? "&" + qs : ""));
}

Everything else looks correct:

• Tabbed page with query param support ✅
• AddPlotButton writer-only check ✅
• NavBar chain link removed ✅
• Published states scoped per tab ✅
• No state leakage between tabs ✅

Verdict: REQUEST CHANGES

Summary

The tabbed /create consolidation is close, but the backward-compat redirect for /chain drops incoming query params, which breaks deep links into the Add Plot flow.

Findings

• [high] /chain does not forward storyline (or any other) query params despite the comment saying it does.
  • File: src/app/chain/page.tsx:8
  • Suggestion: Preserve the incoming search params when redirecting, e.g. redirect /chain?storyline=123 to /create?tab=chain&storyline=123. As written, old links lose the preselected storyline and no longer satisfy the deep-link/prefill behavior.

Decision

Request changes. The redirect needs to preserve query params so the old chain entry points continue to land on the correct prefilled Add Plot state.

T2b APPROVE

Blocker fixed: /chain redirect now awaits searchParams and forwards all query params (excluding tab). /chain?storyline=123 → /create?tab=chain&storyline=123 ✅

Verdict: APPROVE

Summary

The follow-up fixes the backward-compat redirect so old /chain deep links preserve their query params when landing on the unified /create flow. The combined create/chain experience now matches issue #331.

Findings

• [low] The prior blocker is resolved: /chain now forwards incoming search params into /create?tab=chain..., so old storyline deep links still prefill the Add Plot tab correctly.
  • File: src/app/chain/page.tsx:8
  • Suggestion: None.

Decision

Approve. The tabbed /create flow, writer-only story shortcut, nav cleanup, and redirect behavior now align with the requested scope, and local npm run build plus npm run typecheck both pass.

Verdict: APPROVE

Summary

The follow-up removes the lint-blocking state update effect without changing the approved behavior. The unified /create flow and /chain redirect remain correct on the current head.

Findings

• [low] The storyline prefill now relies on initial query-param state instead of an effect, which avoids the react-hooks/set-state-in-effect lint violation while preserving the expected deep-link behavior.
  • File: src/app/create/page.tsx:99
  • Suggestion: None.

Decision

Approve. The current PR head remains within issue #331 scope, and local npm run build plus npm run typecheck both pass.